Re: [PATCH v6 8/8] media: qcom: camss: Enable C-PHY where available

On Wed, Jun 03, 2026 at 01:30:46AM +0200, David Heidelberg wrote:
> After all the changes done we can now safely enable C-PHY for a SoC
> where it's available.
>
> Acked-by: Cory Keitz <[email protected]>
> Reviewed-by: Bryan O'Donoghue <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
Reviewed-by: Frank Li <[email protected]>
>  drivers/media/platform/qcom/camss/camss.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index db4e14a84a95f..555c53343a1e9 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -4761,21 +4761,21 @@ static int camss_parse_endpoint_node(struct device *dev,
>  	struct v4l2_fwnode_endpoint vep = { { 0 } };
>  	unsigned int i;
>  	int ret;
>
>  	ret = v4l2_fwnode_endpoint_parse(ep, &vep);
>  	if (ret)
>  		return ret;
>
> -	/*
> -	 * Most SoCs support both D-PHY and C-PHY standards, but currently only
> -	 * D-PHY is supported in the driver.
> -	 */
> -	if (vep.bus_type != V4L2_MBUS_CSI2_DPHY) {
> +	switch (vep.bus_type) {
> +	case V4L2_MBUS_CSI2_CPHY:
> +	case V4L2_MBUS_CSI2_DPHY:
> +		break;
> +	default:
>  		dev_err(dev, "Unsupported bus type %d\n", vep.bus_type);
>  		return -EINVAL;
>  	}
>
>  	csd->interface.csiphy_id = vep.base.port;
>
>  	mipi_csi2 = &vep.bus.mipi_csi2;
>  	lncfg->num_data = mipi_csi2->num_data_lanes;
>
> --
> 2.53.0
>