Re: [PATCH v3 04/10] clk: qcom: clk-rpm: add msm8960 compatible

On Mon, Jun 01, 2026 at 01:36:48PM +0000, Antony Kurniawan Soemardi wrote:
> On 6/1/2026 6:38 PM, Dmitry Baryshkov wrote:
> > On Mon, Jun 01, 2026 at 03:51:17PM +0700, Antony Kurniawan Soemardi via B4 Relay wrote:
> > > From: Antony Kurniawan Soemardi <[email protected]>
> > > 
> > > Add support for the "qcom,rpmcc-msm8960" compatible string to the
> > > RPM clock driver.
> > > 
> > > msm8960 uses the same RPM clock descriptions as apq8064, so reuse
> > > rpm_clk_apq8064 for this compatible.
> > > 
> > > Tested-by: Rudraksha Gupta <[email protected]>
> > > Signed-off-by: Antony Kurniawan Soemardi <[email protected]>
> > > ---
> > >   drivers/clk/qcom/clk-rpm.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > 
> > On the other hand... You have added APQ8064 strings as a fallback. Is
> > this change really needed until you actually have SoC-specific quirks?
> 
> The fallback was recommended by Konrad in the initial review:
> https://lore.kernel.org/all/[email protected]/
> 
> As for SoC specific quirks, I don't have anything planned right now about it
> though...

So, I think, this patch can be dropped. The entry for APQ8064 should
work already.

-- 
With best wishes
Dmitry