Re: [PATCH v2] gpio: qcom_spmi_gpio: move PM8998 GPIO from legacy pmic driver

On 05/06/2026 17:09, Petr Hodina via B4 Relay wrote:
> From: Petr Hodina <[email protected]>
> 
> Move the "qcom,pm8998-gpio" compatible from the legacy driver
> qcom_pmic_gpio.c to qcom_spmi_gpio.c. Enables on PM8998-based boards
> (sdm845: SHIFT 6mq, Pixel 3, OnePlus 6, Poco F1, Sony Xperia Akatsuki)
> the Volume UP gpio-key.
> 
> Signed-off-by: Petr Hodina <[email protected]>
> ---
> Move the "qcom,pm8998-gpio" compatible from the legacy driver
> qcom_pmic_gpio.c to qcom_spmi_gpio.c. Enables on PM8998-based boards
> (sdm845: SHIFT 6mq, Pixel 3, OnePlus 6, Poco F1, Sony Xperia Akatsuki)
> the Volume UP gpio-key.
> 
> Suggested-by: Neil Armstrong <[email protected]>

Reviewed-by: Casey Connolly <[email protected]>

> ---
> Changes in v2:
> - Reworked per Neil Armstrong's suggestion on v1: migrate PM8998 to the
>   modern qcom_spmi_gpio driver instead of extending the legacy
>   qcom_pmic_gpio.c.
> - Dropped "gpio: qcom_pmic_gpio: implement standard pinconf parameters".
> - Dropped "gpio: qcom_pmic_gpio: don't reset pull on direction change".
> - Replaced with a single qcom_spmi_gpio.c patch that claims the
>   qcom,pm8998-gpio compatible.
> - Link to v1: https://patch.msgid.link/[email protected]
> 
> To: Sumit Garg <[email protected]>
> To: [email protected]
> To: [email protected]
> Cc: Casey Connolly <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Tom Rini <[email protected]>
> Cc: Rui Miguel Silva <[email protected]>
> Cc: Petr Hodina <[email protected]>
> Cc: Luca Weiss <[email protected]>
> Cc: David Wronek <[email protected]>
> Cc: Jens Reidel <[email protected]>
> ---
>  drivers/gpio/qcom_pmic_gpio.c | 1 -
>  drivers/gpio/qcom_spmi_gpio.c | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/qcom_pmic_gpio.c b/drivers/gpio/qcom_pmic_gpio.c
> index 4458c55cd3d..6215f794e09 100644
> --- a/drivers/gpio/qcom_pmic_gpio.c
> +++ b/drivers/gpio/qcom_pmic_gpio.c
> @@ -344,7 +344,6 @@ static int qcom_gpio_probe(struct udevice *dev)
>  static const struct udevice_id qcom_gpio_ids[] = {
>  	{ .compatible = "qcom,pm8916-gpio" },
>  	{ .compatible = "qcom,pm8994-gpio" },	/* 22 GPIO's */
> -	{ .compatible = "qcom,pm8998-gpio" },
>  	{ .compatible = "qcom,pms405-gpio" },
>  	{ .compatible = "qcom,pm6125-gpio" },
>  	{ .compatible = "qcom,pm8150-gpio" },
> diff --git a/drivers/gpio/qcom_spmi_gpio.c b/drivers/gpio/qcom_spmi_gpio.c
> index 1a7c7c48dfc..8c3323b23b7 100644
> --- a/drivers/gpio/qcom_spmi_gpio.c
> +++ b/drivers/gpio/qcom_spmi_gpio.c
> @@ -751,6 +751,7 @@ static const struct udevice_id qcom_spmi_pmic_gpio_ids[] = {
>  	{ .compatible = "qcom,pm8550b-gpio" },
>  	{ .compatible = "qcom,pm8550ve-gpio" },
>  	{ .compatible = "qcom,pm8550vs-gpio" },
> +	{ .compatible = "qcom,pm8998-gpio" },
>  	{ .compatible = "qcom,pmk8550-gpio" },
>  	{ .compatible = "qcom,pmr735d-gpio" },
>  	{ }
> 
> ---
> base-commit: 1f89ddd61cd8c27a3dc1fc7edbeccb55d424eb72
> change-id: 20260601-qcom-gpio-98e85ab22647
> 
> Best regards,
> --  
> Petr Hodina <[email protected]>
> 
> 

-- 
// Casey (she/her)