Re: [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475

Krzysztof Kozlowski <[email protected]> Thu, 30 Jul 2026 11:03:22 +0200
Newsgroups org.kernel.vger.phone-devel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb
Message-ID <20260730-resourceful-scrupulous-goshawk-c9ea53@quoll>
On Wed, Jul 29, 2026 at 03:48:24PM -0400, Esteban Urrutia wrote:
> Add compatible string for pmic-glink.

First, not true. You did not add compatible for pmic-glink.

Second, that's redundant. You just repeated subject and the diff
(although incorrectly). Explain why this is not compatible with existing
variants, writing bindings EXPLICITLY ask for that.


Best regards,
Krzysztof