Re: [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers

--eissgc2t76naakqg
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Subject: Re: [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2
 amplifiers
MIME-Version: 1.0

Hello,

On Sun, Aug 02, 2026 at 02:42:41PM +0200, David Heidelberg wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>

Please don't include <linux/mod_devicetable.h>, that is going away soon.
Also <linux/i2c.h> already provides i2c_device_id and of_device_id
(ie. the two structures that used to be defined in
<linux/mod_devicetable.h> that you're using), so just drop the #include
for <mod_devicetable.h>.

> [...]
> +static const struct i2c_device_id tfa98xx_i2c_id[] = {
> +	{ "tfa9894", (kernel_ulong_t)&tfa9894_chip },

Please make this

	{ .name = "tfa9894", .driver_data = (kernel_ulong_t)&tfa9894_chip },

Best regards
Uwe

--eissgc2t76naakqg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpvwfEACgkQj4D7WH0S
/k5ofAf/fcXOQAhsDuQI1vXZjfYD+Nu2PG5sMkw/QbLri499oQfMbAfRG0JWATEF
QlWrFmVUB03381JLDXyXWtkO5evnjkldLr3bqGY7QevsfpxmOHDV9zLomJjfAqyL
RmIcbr5btKIh2FZJRZslqHYoKiG7SeNZJLyxeYU4lW8vZcohMMRHlPGSCEC7RoNI
sJdx+JMXR+ZHBOuwOrObZDxREbyQwdSnxD1gEEwmXEcpb0rZUWVIEZKXNekbV2XN
izdCJ/P/vwPVNl7yrZLjlzfD6t2AFmYBYIq4kLKM1vrAd8gxMcxwTQH+XKnFNaWC
RZQ+MsjqlG8Lw4wj970ztO4ky/yXFQ==
=/KIq
-----END PGP SIGNATURE-----

--eissgc2t76naakqg--