Re: [PATCH v5 3/6] ARM: dts: qcom: apq8064: Fix USB controller clocks
Antony Kurniawan Soemardi <[email protected]>
| Newsgroups | org.kernel.vger.phone-devel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/4/2026 1:34 PM, Alexandre MINETTE via B4 Relay wrote: > From: Alexandre MINETTE <[email protected]> > > The APQ8064 HS USB controller nodes describe the transceiver clock as > "core", but the ChipIdea MSM glue expects "core" to be the controller > fabric clock and "fs" to be the transceiver clock. > > This mismatch can leave the fabric clock disabled while the controller is > accessed. Some boards may tolerate that if the clock is already enabled > elsewhere, but it is not a correct description of the hardware. > > Describe the RPM Daytona fabric clock as "core", the AHB clock as > "iface", and the transceiver clock as "fs" for all APQ8064 HS USB > controllers. Without this, USB does not probe reliably on Samsung Galaxy > S4 because the fabric clock remains disabled. oh sorry, I forgot to mention that, depending on the feedback on msm8960's patch [1], we might end up swapping the Daytona fabric and HS1_H clocks. So, Daytona fabric would be the "iface" and HS1_H would be the "core". [1] https://lore.kernel.org/all/[email protected]/ -- Thanks, Antony K. S.