Re: [PATCH v3 1/2] dt-bindings: media: i2c: dongwoon,dw9714: Document DW9714A and V variant

On 10/08/2026 11:38, Sakari Ailus wrote:
> Hi David,
> 
> On Mon, Aug 03, 2026 at 11:50:25AM +0200, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <[email protected]>
>>
>> DW9714A is successor of DW9714 and DW9714V is successor of the DW9714A.
>>
>> All actuators are backward compatible, but they do introduce new features,
>> such as Smart Actuator Control (SAC) mode which can minimize the
>> mechanical vibration and achieve very fast mechanical settling time.
>> Support for SAC can be implemented in the future.
> 
> What kind of configuration does SAC require? Such things generally aren't
> configured from the userspace, compare e.g. with the dw9719 bindings
> discussion.

I don't have extra deep insight (except basic how the sensor works).

By default all dw9714* sensors starts in the default "legacy" mode.

The clanker after looking at datasheets and kernel struct produced, if it make 
sense:

the mode and the vibration period (SAC_CFG/PRESC/SACT) have to match
the mechanical tVIB of the actuator and lens assembly of the given camera
module, the same way dongwoon,aac-mode/aac-timing/clock-presc do for
dongwoon,dw9768 and dongwoon,sac-mode/vcm-prescale for dongwoon,dw9719.
Those properties are left out until there is driver support and measured
values; note the DW9714V mode set differs from DW9719's, so its enum cannot
be reused as is.

David

> 
>>
>> Nit: fix typo in description by removing duplicate information.
>>
>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>> Signed-off-by: David Heidelberg <[email protected]>
>> ---
>>   .../devicetree/bindings/media/i2c/dongwoon,dw9714.yaml     | 14 +++++++++++---
>>   1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
>> index 66229a3dc05d6..7c2769e6c4880 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
>> @@ -5,22 +5,30 @@ $id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9714.yaml#
>>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   
>>   title: Dongwoon Anatech DW9714 camera voice coil lens driver
>>   
>>   maintainers:
>>     - Krzysztof Kozlowski <[email protected]>
>>   
>>   description:
>> -  DW9174 is a 10-bit DAC with current sink capability. It is intended for
>> -  driving voice coil lenses in camera modules.
>> +  10-bit DAC with current sink capability. It is intended for driving
>> +  voice coil lenses in camera modules.
>>   
>>   properties:
>>     compatible:
>> -    const: dongwoon,dw9714
>> +    oneOf:
>> +      - items:
>> +          - const: dongwoon,dw9714v
>> +          - const: dongwoon,dw9714a
>> +          - const: dongwoon,dw9714
>> +      - items:
>> +          - const: dongwoon,dw9714a
>> +          - const: dongwoon,dw9714
>> +      - const: dongwoon,dw9714
>>   
>>     reg:
>>       maxItems: 1
>>   
>>     powerdown-gpios:
>>       description:
>>         XSD pin for shutdown (active low)
>>   
>>
> 

-- 
David Heidelberg