Re: [PATCH v3 1/2] dt-bindings: usb: Add Parade PS5169 redriver bindings

On Mon, Aug 10, 2026 at 11:31:36PM -0400, Esteban Urrutia wrote:

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

> +
> +  parade,dp-eq-db:
> +    description:
> +      Equalization for DP channels.
> +      For example, <6 5> denotes an equalization of 6.5 dB.
> +    oneOf:
> +      - items:
> +          - enum: [ 2, 8, 10 ]
> +          - const: 0
> +      - items:
> +          - enum: [ 5, 6, 7, 8, 9 ]
> +          - const: 5

Eh, this is on me. I did not pay attention that values are fractional.
You should not be a list, but expressed as a single value, which is not
possible with int32. This might be the only ever practical use of mB :),
but I doubt that any engineer would find that readable, so let's go to
your previous code - direct register values - for all three properties.

Sorry for the mess.

> +
> +  parade,usb-rx-eq-db:
> +    description:
> +      Equalization for USB receive channels.
> +      For example, <5 2> denotes an equalization of 5.2 dB.
> +    oneOf:
> +      - items:
> +          - enum: [ 5, 11 ]
> +          - const: 2
> +      - items:
> +          - enum: [ 6, 7, 8 ]
> +          - const: 0
> +      - items:
> +          - const: 8
> +          - const: 8
> +      - items:
> +          - const: 9
> +          - const: 6
> +      - items:
> +          - const: 10
> +          - const: 4
> +
> +  parade,usb-tx-eq-db:
> +    description:
> +      Equalization for USB transmit channels.
> +      For example, <6 5> denotes an equalization of 6.5 dB.
> +    oneOf:
> +      - items:
> +          - enum: [ 2, 8, 10 ]
> +          - const: 0
> +      - items:
> +          - enum: [ 5, 6, 7, 8, 9 ]
> +          - const: 5

Best regards,
Krzysztof