Re: [PATCH v2 5/6] PCI/VGA: Convert to use acpi_dev_is_video_device() helper

On Mon, Jul 20, 2026 at 12:04:04PM +0300, Ilpo Järvinen wrote:
> On Tue, 14 Jul 2026, Andy Shevchenko wrote:

...

> >  #if defined(CONFIG_ACPI)
> > -	struct acpi_device *adev = ACPI_COMPANION(dev);
> > -
> > -	return adev && !strcmp(acpi_device_hid(adev), ACPI_VIDEO_HID);
> > +	return acpi_dev_is_video_device(ACPI_COMPANION(dev));
> >  #else
> >  	return false;
> >  #endif
> 
> How about adding a stub for acpi_dev_is_video_device() if !CONFIG_ACPI
> so this code can do without ifdeffery?

So far it's the only the case where it may gain something, but overall
it's not required, all other current users already implied that. So,
I do not see the value in this churn. When we have more such users,
we may reconsider.

-- 
With Best Regards,
Andy Shevchenko