Re: [PATCH v2] platform/x86: thinkpad_acpi: Fix USB-C Security probe failure on unsupported platforms
Ilpo Järvinen <[email protected]>
| Newsgroups | org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-acpi |
|---|---|
| Message-ID | <178456545819.1362.9472740011574577381.b4-ty@b4> |
On Wed, 15 Jul 2026 10:02:05 +0900, Vishnu Sankar wrote:
> On systems where the USCS ACPI method is absent, acpi_evalf() returns
> AE_NOT_FOUND which maps to -EIO. This caused tpacpi_usbc_security_init()
> to propagate the error and thinkpad_acpi failed to probe entirely on
> unsupported platforms.
>
> Fix this by checking for USCS method presence with acpi_has_method() before
> attempting to call it, returning -ENODEV immediately if absent.
> This follows the same pattern used by other subdrivers in thinkpad_acpi.c.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: Fix USB-C Security probe failure on unsupported platforms
commit: 10bae492e814eeb1013ab9bc08f655d14fca46e4
--
i.