Re: [PATCH 1/8] ASoC: aw88399: extract shared device library
Marco Giunta <[email protected]>
| Newsgroups | org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-acpi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <DS7PR19MB77243856ADFA26B9878B1CAFFCC02@DS7PR19MB7724.namprd19.prod.outlook.com> |
> I know you're just moving things around, but wouldn't it be useful to > modernize these to BIT() and GENMASK() in an additional patch. Hi Ilpo, Thanks for the suggestion. Since Mark has already applied patches 1-5 to broonie/sound, a BIT()/GENMASK() conversion would need to be a separate follow-up series at this point. Independent of the above point, I would appreciate your perspective on scope as a first-time contributor. I was under the impression that a patch series like this should contain only what's strictly necessary to enable the new driver, hence why I left the base AWINIC code untouched as much as possible. Would a modernization patch have been acceptable as part of the original series, or is a standalone follow-up the right approach here? Best regards, Marco