Re: [PATCH v2] platform/x86: ideapad-laptop: Fix driver unregistration order

Hi Ilpo,

On Fri, 2026-07-24 at 14:54 +0300, Ilpo Järvinen wrote:
> On Thu, 23 Jul 2026, Rong Zhang wrote:
> 
> > There are two drivers in the ideapad-laptop module: a wmi_driver and a
> > platform_driver. The former is registered before the latter, but the
> > unregistration order is the same as the init one instead of the reverse.
> > 
> > Fix the driver unregistration order by reversing it.
> > 
> > Fixes: f32e02417614 ("platform/x86: ideapad-laptop: support for more special keys in WMI")
> > Reviewed-by: Mark Pearson <[email protected]>
> > Signed-off-by: Rong Zhang <[email protected]>
> > ---
> > Changes in v2:
> > - Fix a typo in title
> 
> Perhaps too used to writing "dead" so fingers kept typing... I can never 
> type "roof" succesfully myself, my fingers always do "root" instead. :-)

An ideadl root does not leak on rainy days ;-P

> 
> Anyway, I've applied this but took out the Fixes tag, unless you've some 
> real bug in mind related to it?

Makes sense. It's not buggy as the two driver has no dependency on each
other.

> 
> I also added Suggested-by me to take some blame (if necessary).

Ahh, forgot that!

> 
> Thanks for the patch and Mark for review.

And thanks for reviewing and fixing my patch ;-)

Thanks,
Rong