Re: [PATCH v2] platform/x86: dell-dw5826e: fix ACPI _DSM function index and bitmask usage
Ilpo Järvinen <[email protected]> Fri, 24 Jul 2026 19:29:00 +0300
| Newsgroups | org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <178491054055.24171.10115266175495769020.b4-ty@b4> |
On Fri, 24 Jul 2026 18:25:33 +0530, [email protected] wrote: > PALC_DSM_FN_TRIGGER_PLDR was defined as BIT(1) (value 2). > > acpi_evaluate_dsm() expects a 0-based function index integer (0, 1, > 2, ...), whereas acpi_check_dsm() expects a bitmask of supported > function indices (BIT(1), BIT(2), ...). > > Because PALC_DSM_FN_TRIGGER_PLDR was defined as BIT(1), > acpi_evaluate_dsm() was evaluating Function Index 2 instead of Function > Index 1, while acpi_check_dsm() was checking for Function Index 1 > support. > > [...] Thank you for your contribution, it has been applied to my local review-ilpo-fixes branch. Note it will show up in the public platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86: dell-dw5826e: fix ACPI _DSM function index and bitmask usage commit: 39490ec6063d9dc3d995b7b48fc5106cd361a547 -- i.