Re: [PATCH v3 0/7] platform/x86/amd/pmf: Add 1AH_M80H support and accumulator based NPU metrics
Ilpo Järvinen <[email protected]> Mon, 27 Jul 2026 21:56:55 +0300
| Newsgroups | org.kernel.vger.platform-driver-x86 |
|---|---|
| Message-ID | <178517861557.16876.100614585681623928.b4-ty@b4> |
On Thu, 23 Jul 2026 16:45:27 +0530, Shyam Sundar S K wrote:
> This series cleans up the PMF-SMU mailbox handling, adds support for the
> AMD 1AH_M80H (Family 1AH Model 80H) platform, and introduces NPU metrics
> retrieval for it based on a firmware managed DRAM metrics table.
>
> Today the SMU mailbox register offsets are hardcoded in the send path,
> which does not scale to platforms that use a different mailbox layout.
> The first two patches address this: patch 1 moves the offsets into a
> per-SoC struct amd_pmf_smu_regs carried as PCI driver_data, so all
> existing platforms share a single legacy instance and new platforms only
> add a table entry. Patch 2 then adds the 1AH_M80H device/ACPI IDs and its
> extended mailbox, which uses three argument registers to return the
> 64-bit DRAM address and size of the metrics table.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/7] platform/x86/amd/pmf: Use per-SoC smu_regs struct for SMU mailbox registers
commit: e860e561926bf75e323d43fe59a9bf25d2ef33a3
[2/7] platform/x86/amd/pmf: Add 1AH_M80H device IDs and extended SMU mailbox registers
commit: 2f9db5881fb37e5723bd88f939c7bffb8e7789a3
[3/7] platform/x86/amd/pmf: Move metrics code to dedicated file
commit: 2e34aca48f42ef0d3ff95d79e82268b2eacae486
[4/7] platform/x86/amd/pmf: Add missing newline in dev_err message
commit: d19eca503861824a6c8f8eea7eabc79e14479f84
[5/7] platform/x86/amd/pmf: Use upper/lower_32_bits() in amd_pmf_set_dram_addr()
commit: 9f29ec1f46d03a7b633c5d9a668ece059d539d4c
[6/7] platform/x86/amd/pmf: Refactor NPU metrics for platform extensibility
commit: 17f3e140d09da4d17dadef82ab67547e71215a64
[7/7] platform/x86/amd/pmf: Add 1AH_M80H metrics table and NPU metrics support
commit: 641b41a7a12537f8898b1e14c62e0d85a8b872c2
--
i.