Re: [PATCH 1/2] hp-wmi: Modernize hp_wmi_perform_query() to use the modern API

Am 01.08.26 um 16:20 schrieb yahia ahmed:

> Hi,
>
> Currently hp_bioscfg and hp_wmi will both collide to register in the
> 5FB7F034-2C63-45E9-BE91-3D44E2C707E4 GUID, so if we modernize to use
> the wmi interface we will lock one of the drivers out, So how should
> we optimally handle them?
>
> Best regards,
> yahia

Oh no :/

I suggest that you use the component framework to register a component inside the hp-wmi driver
when probing a WMI device. The hp-bioscfg driver can then register a component master to bind
to this component. During binding the WMI device handled by the hp-wmi driver can be shared
with the hp-bioscfg driver, so both can use it.

This however might turn out to be a bit complicated, do you have a device where you can test
both drivers? If no, then i suggest that you focus on removing all usage of wmi_install_notify_handler()
from the hp-wmi driver instead. This does not require that you convert the whole driver to the
new bus-based API.

Thanks,
Armin Wolf