Re: [PATCH 1/2] hp-wmi: Modernize hp_wmi_perform_query() to use the modern API

Am 01.08.26 um 18:09 schrieb yahia ahmed:

> Hi,
>
> I think that the component framework will be better though I dont have
> all the hardware to test stuff like legacy RFKill, I agree for now we
> should remove usage of wmi_install_notify_handler() though I will await
> ilpo's response maybe he has another idea.
>
> Best regards,
> yahia

Alight, keep in mind that the hp-wmi and hp-wmi-sensors driver seem to use the
same WMI event GUID (95F24279-4D7B-4334-9387-ACCDC67EF61C) for handling events,
so you have to move both of them away from wmi_install_notify_handler().

For this i suggest that you introduce a separate WMI driver for the event GUID,
where both drivers can register notifiers to receive the ACPI object payload
of the WMI event (see drivers/platform/x86/uniwill/uniwill-wmi.c for inspiration).
In this case i would ignore the fact that the ACPI object-based WMI event callback
is deprecated, so you do not have to rework the whole event handling in both drivers.

Thanks,
Armin Wolf