[PATCH 3/3] platform/x86: asus-armoury: Prevent disabling dGPU when in use
Marco Scardovi <[email protected]> Wed, 5 Aug 2026 20:28:08 +0200
| Newsgroups | org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Check ASUS_WMI_DEVID_DGPU_POWER_STATE before attempting to disable the
discrete GPU in dgpu_disable_current_value_store(). Return -EBUSY if the
dGPU is currently active and in use.
Fixes: f99eb098090e ("platform/x86: asus-armoury: move existing tunings to asus-armoury module")
Suggested-by: Denis Benato <[email protected]>
Signed-off-by: Marco Scardovi <[email protected]>
---
drivers/platform/x86/asus-armoury.c | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index f745924af8a8..2d5ca75bc727 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -515,13 +515,25 @@ static ssize_t dgpu_disable_current_value_store(struct kobject *kobj,
if (err)
return err;
- if (asus_armoury.gpu_mux_dev_id) {
- err = armoury_get_devstate(NULL, &result, asus_armoury.gpu_mux_dev_id);
- if (err)
- return err;
- if (!result && disable) {
- pr_warn("Cannot disable dGPU when the MUX is in dGPU mode\n");
- return -EBUSY;
+ if (disable) {
+ if (asus_armoury.gpu_mux_dev_id) {
+ err = armoury_get_devstate(NULL, &result, asus_armoury.gpu_mux_dev_id);
+ if (err)
+ return err;
+ if (!result) {
+ pr_warn("Cannot disable dGPU when the MUX is in dGPU mode\n");
+ return -EBUSY;
+ }
+ }
+
+ if (armoury_has_devstate(ASUS_WMI_DEVID_DGPU_POWER_STATE)) {
+ err = armoury_get_devstate(NULL, &result, ASUS_WMI_DEVID_DGPU_POWER_STATE);
+ if (err)
+ return err;
+ if (result) {
+ pr_warn("Cannot disable dGPU when it is in use\n");
+ return -EBUSY;
+ }
}
}
--
2.55.0