Re: [PATCH v4 10/13] platform/x86: uniwill-wmi: use devm_blocking_notifier_chain_register()
Uwe Kleine-König <[email protected]>
| Newsgroups | org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-acpi,org.kernel.vger.linux-gpio,org.kernel.vger.linux-iio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm |
|---|---|
| Message-ID | <anlSAqWxS7boyJBT@monoceros> |
Hello,
On Sun, Jul 26, 2026 at 10:17:36AM +0000, Eliav Farber wrote:
> int devm_uniwill_wmi_register_notifier(struct device *dev, struct notifier_block *nb)
> {
> - int ret;
> -
> - ret = blocking_notifier_chain_register(&uniwill_wmi_chain_head, nb);
> - if (ret < 0)
> - return ret;
> -
> - return devm_add_action_or_reset(dev, devm_uniwill_wmi_unregister_notifier, nb);
> + return devm_blocking_notifier_chain_register(dev,
> + &uniwill_wmi_chain_head,
> + nb);
> }
I'd remove this function and replace calls to it directly by
devm_blocking_notifier_chain_register().
Best regards
Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmp5UlgACgkQj4D7WH0S /k6sGwf/UZUQmeE+yaDBE/vWSAF4KRfM4BCOpYcTy2/gv7+b5S9qFmFjWZ0HCOoh 3V4X2yJPH6DGRzTHUVXh8dm+ZJMuNjVS01nEMJ1zlyJfJna5Cp0FJDsIhDJRCqc9 y5GYM6P2xKFZLwL5D7FisGULZQmpmrhUXPsKsC/GpSKCplAWSTyGHtfSBPBQQuCh F+5zgE5mG28X8ZNw5bycaSMPtilvT4jot0aIPE3USc7k1tofx/1UcWVBWRaGFYEF nctDHlhw63B2c8e/RcObUVengsA4HeVjy+Xwaf7Pwk/nP0pOQEo6S+zy/rd+/62b 57kF59SGPY7M6iDeGXMEyaXmkbc21A== =62yG -----END PGP SIGNATURE-----