Re: [PATCH v4 02/13] pwm: iqs620a: use devm_blocking_notifier_chain_register()

Uwe Kleine-König <[email protected]> Mon, 10 Aug 2026 06:38:43 +0200

Newsgroups	org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-acpi,org.kernel.vger.linux-gpio,org.kernel.vger.linux-iio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm
Message-ID	<anlRaaztPEu5u6Zn@monoceros>

Hello,

On Sun, Jul 26, 2026 at 10:17:28AM +0000, Eliav Farber wrote:
> Replace the blocking_notifier_chain_register() +
> devm_add_action_or_reset() pattern with a single call to
> devm_blocking_notifier_chain_register(), removing the
> iqs620_pwm_notifier_unregister() callback.
> 
> Signed-off-by: Eliav Farber <[email protected]>
> ---
>  drivers/pwm/pwm-iqs620a.c | 21 +++------------------
>  1 file changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-iqs620a.c b/drivers/pwm/pwm-iqs620a.c
> index 13e5e138c8e9..12f7b1415ed4 100644
> --- a/drivers/pwm/pwm-iqs620a.c
> +++ b/drivers/pwm/pwm-iqs620a.c
> @@ -173,17 +173,7 @@ static const struct pwm_ops iqs620_pwm_ops = {
>  	.get_state = iqs620_pwm_get_state,
>  };
>  
> -static void iqs620_pwm_notifier_unregister(void *context)
> -{
> -	struct iqs620_pwm_private *iqs620_pwm = context;
> -	int ret;
>  
> -	ret = blocking_notifier_chain_unregister(&iqs620_pwm->iqs62x->nh,
> -						 &iqs620_pwm->notifier);
> -	if (ret)
> -		dev_err(iqs620_pwm->dev,
> -			"Failed to unregister notifier: %d\n", ret);
> -}
>  

Too much remaining whitespace here. Other than that looks ok.

There is no specified merge plan yet, and this depends on patch #1, so
it cannot get applied yet. Given that IMHO patch #1 should change, I
expect there will be a v5 and we can consider application then.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)