Re: [PATCH 3/3] platform/x86: intel_scu_ipc: Handle errors from optional IRQ lookup

Andy Shevchenko <[email protected]> Mon, 10 Aug 2026 10:04:52 +0300

Newsgroups	org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-kernel
Message-ID	<CAHp75Vd+cAOp28btmTzNXMejues5XHdy_BtZvnskshpLkr8=kw@mail.gmail.com>

On Mon, Aug 10, 2026 at 8:26 AM <[email protected]> wrote:

> platform_get_irq_optional() can return errors such as -EPROBE_DEFER,
> but the driver currently stores the return value directly in
> scu_data.irq and continues probing.
>
> Propagate negative errors other than -ENXIO using dev_err_probe(), and
> only assign the IRQ to scu_data.irq when a valid IRQ number is
> returned.

You haven't read the code, have you?
Check the implementation of __intel_scu_ipc_register() in
drivers/platform/x86/intel_scu_ipc.c and act accordingly.

-- 
With Best Regards,
Andy Shevchenko