Re: [PATCH v2] platform/x86: int3472: support the POWER1 GPIO type
Sakari Ailus <[email protected]>
| Newsgroups | org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
Hi Jakob, On Wed, Jul 29, 2026 at 01:03:46PM +0200, Jakob Berg Jespersen wrote: > INT3472 can describe a second sensor power rail as a GPIO of type > POWER1 (0x08), which the driver does not recognise, so the rail is left > unmapped and never enabled: > > int3472-discrete INT3472:01: GPIO type 0x08 unknown; the sensor may > not work > > On the Microsoft Surface Pro 7+ the rear camera's INT3472 (INT347A, > ov8865) has such a pin; without it the ov8865 "dvdd" supply resolves to > a dummy regulator and the sensor never probes. > > Define the POWER0 (0x07) and POWER1 (0x08) GPIO types and map POWER1 to > a regulator with con_id "dvdd" for all devices, the supply the in-tree > ov8865 driver already requests. POWER0 is defined but left unmapped, as > no device that uses it is known. > > Out-of-tree work approached the same rail by exposing it to the sensor > as a new "pwr1" supply (linux-surface PR #1867 for the Surface Pro 9, > PR #2201 for the Pro 7+ ov8865); mapping POWER1 to the existing "dvdd" > keeps the change contained to int3472. > > With this change the Surface Pro 7+ rear camera probes and streams > reliably. > > Link: https://github.com/linux-surface/linux-surface/pull/1867 > Link: https://github.com/linux-surface/linux-surface/pull/2201 > Suggested-by: Sakari Ailus <[email protected]> > Signed-off-by: Jakob Berg Jespersen <[email protected]> Could you resend v2 (or v3, if there are changes) this and cc linux-media list as well? (The MAINTAINERS change adding that list isn't merged yet.) -- Regards, Sakari Ailus