acer-wmi: Acer Predator PH315-54 Turbo button handled by WMI but model lacks DMI quirk
"Stefano Dall'Olio" <[email protected]>
| Newsgroups | org.kernel.vger.platform-driver-x86 |
|---|---|
| Message-ID | <CAGOax8zUMxzOGg+bgmQVtVwVOMHUnpXuUS_=sqT9zcudNkjUrA@mail.gmail.com> |
Hello,
I would like to report a possible missing DMI quirk in
drivers/platform/x86/acer-wmi.c for the Acer Predator Helios 300
PH315-54.
Hardware:
Vendor: Acer
Product: Predator PH315-54
Board: QX60_TLS
BIOS: V1.15 (2023-06-29)
CPU: Intel Core i7-11800H
GPU: NVIDIA GeForce RTX 3070 Laptop GPU
Tested system:
Ubuntu 26.04 LTS
kernel 7.0.0-29-generic
acer_wmi built as module
The physical Turbo button above the keyboard does not activate Turbo
mode and its LED remains off.
acer_wmi loads normally:
acer_wmi: Acer Laptop ACPI-WMI Extras
acer_wmi: Function bitmap for Communication Button: 0x801
The system exposes an Acer WMI hotkeys input device and the Acer
gaming WMI interfaces are present.
The relevant module parameters are:
force_series=0
force_caps=-1
ec_raw_mode=N
cycle_gaming_thermal_profile=Y
predator_v4=N
No platform_profile interface is exposed.
I traced the Turbo button using a kprobe on the actual compiled
acer_toggle_turbo symbol:
acer_toggle_turbo.isra.0 [acer_wmi]
Every physical press of the Turbo button reaches this function. In one
test, 11 button presses produced exactly 11 kprobe hits with zero
misses:
acer_turbo 11 0
A kretprobe also showed that acer_toggle_turbo.isra.0 returned 0 on
every tested press.
Therefore the hardware button, firmware WMI notification and acer_wmi
event handling path appear to work correctly.
I then inspected the acer-wmi.ko shipped with the running Ubuntu
kernel. It contains:
Acer Predator PH315-53
Predator PH315-53
quirk_acer_predator_ph315_53
but there is no PH315-54 DMI entry.
The PH315-53 quirk appears particularly relevant because it enables:
.turbo = 1
.cpu_fans = 1
.gpu_fans = 1
The PH315-54 is the following generation of the same Predator Helios
300 family and has the physical Predator Turbo button.
A possible candidate would therefore be to add a PH315-54 DMI match
using the existing quirk_acer_predator_ph315_53, e.g. conceptually:
{
.callback = dmi_matched,
.ident = "Acer Predator PH315-54",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_MATCH(DMI_PRODUCT_NAME, "Predator PH315-54"),
},
.driver_data = &quirk_acer_predator_ph315_53,
},
I have not loaded or functionally tested this proposed quirk, because
I preferred not to maintain an out-of-tree kernel module merely for
the Turbo button. I am therefore reporting this as a possible missing
hardware quirk rather than claiming the above patch is proven correct.
I can provide additional WMI traces, DMI information, ACPI tables or
test a maintainer-provided patch if useful.
Regards,
Stefano Dall'Olio
--
_
Stefano Dall'Olio
IT Manager
M [email protected]
W www.memooria.org
Memooria srl impresa sociale
Corso Cavour 56, 41121 Modena (MO)
p.iva 01636220194 (SDI: USAL8PV) - tel/fax +39 02 37904002