Re: [PATCH v3 5/6] platform/x86: bitland-mifs-wmi: Add per-machine ops table
Rsplwe <[email protected]>
| Newsgroups | org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi, Regarding the handling of `has_full_speed`: when a machine does not have a Full Speed mode, `PLATFORM_PROFILE_PERFORMANCE` should still be exposed if the machine supports the Performance mode. In other words, the absence of Full Speed should not make `BALANCED_PERFORMANCE` the highest available profile. For machines without Full Speed, the expected profile choices should be: `low-power` / `balanced` / `performance` where `PLATFORM_PROFILE_PERFORMANCE` maps to the machine's highest available performance mode. Therefore, `has_full_speed` should probably distinguish whether the machine has a separate Full Speed mode, while the profile choice logic should ensure that `PLATFORM_PROFILE_PERFORMANCE` remains available when Performance is the highest supported mode.