Re: [PATCH] platform/x86: asus-armoury: add support for FX517ZR

On 7/29/26 13:09, AbdElRahman Soliman wrote:
> Add DMI match and power-limit table entry for the ASUS TUF Dash F15
> (2022), board FX517ZR, an Alder Lake + RTX 3070 laptop.
>
> AC and DC min/max values for ppt_pl1_spl, ppt_pl2_sppt,
> nv_dynamic_boost and nv_temp_target were read from the sliders in
> ASUS Armoury Crate's manual performance-tuning mode on Windows for
> this exact model, since ASUS does not publish these limits on the Web.
>
> Tested locally: values now report correctly via 'asusctl armoury
> list' instead of unavailable, and Dynamic Boost via nvidia-powerd
> measurably raises GPU power limit under load, consistent with the
> 80W base + 25W boost = 105W max TGP in ASUS's own spec sheet for
> this configuration.
>
> Assisted-by: Claude:claude-sonnet-5
Hi,

Thanks for this.

I would say remove the "Tested locally" paragraph: guidelines says
that commit messages are to be written in the second person as if
you were telling git what to do.

Also I personally never used a commit message so long and
a shorter one will be absolutely be fine too.

Next revision use the -v2 flag and don't forget to email me too.

If you need further help just tell me, thanks!
> Signed-off-by: AbdElRahman Soliman <[email protected]>
> ---
>  drivers/platform/x86/asus-armoury.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index bc899bec7..46c308ba8 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -975,6 +975,32 @@ static const struct dmi_system_id power_limits[] = {
>  			.requires_fan_curve = true,
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "FX517ZR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 28,
> +				.ppt_pl1_spl_max = 85,
> +				.ppt_pl2_sppt_min = 28,
> +				.ppt_pl2_sppt_max = 135,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 25,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 25,
> +				.ppt_pl1_spl_max = 45,
> +				.ppt_pl2_sppt_min = 35,
> +				.ppt_pl2_sppt_max = 60,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "FX607VU"),