Re: [PATCH 0/2] platform/x86: ISST: Two ioctl input validation fixes

Ilpo Järvinen <[email protected]>
Newsgroups org.kernel.vger.platform-driver-x86,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID <178706205486.20251.10551775029465079194.b4-ty@b4>
On Fri, 07 Aug 2026 23:40:01 +0900, HyeongJun An wrote:

> Two out-of-bounds accesses reachable from the ISST character device
> ioctls, both from user-supplied index values that are not bounded before
> use.
> 
> The first is an off-by-one on socket_id in the CLOS association ioctl,
> plus a missing NULL check on the resulting instance pointer. The same
> file already gets both of these right in get_instance(), which rejects
> pkg_id with in_range(pkg_id, 0, topology_max_packages()) and then checks
> the instance for NULL before returning it.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/2] platform/x86: ISST: Validate socket ID in clos_assoc ioctl
      commit: 9100b71ea369c2d9cefd3ed607f683087ff4b03c
[2/2] platform/x86: ISST: Validate level in perf mask ioctls
      commit: 74bb8134e55402cdd809d1613cac40765c6711c8

--
 i.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.