Re: [PATCH v2 5/6] rust: Add dma_fence abstractions

Onur Özkan <[email protected]>
Newsgroups org.kernel.vger.rcu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.rust-for-linux
Message-ID <[email protected]> 
On Tue, 16 Jun 2026 17:28:04 +0200
Danilo Krummrich <[email protected]> wrote:

> On Tue Jun 16, 2026 at 4:51 PM CEST, Onur Özkan wrote:
> > repr(C) only makes sense when the type have multiple fields.
> 
> I don't think that's universally true. repr(transparent) guarantees the layout
> and ABI match the inner field. The wrapper is passed through calls exactly as
> the field would be. repr(C) guarantees C-compatible layout and makes the type
> follow the platform's C ABI for passing an aggregate, which isn't always how the
> bare field is passed.

I was too focused on the field ordering perspective during the review, sorry for
that.

Onur
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.