Re: [PATCH] rust: device: avoid trailing ; in printing macros
"Danilo Krummrich" <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,dev.linux.lists.driver-core,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Thu Jul 16, 2026 at 4:28 PM CEST, Miguel Ojeda wrote: > Thanks, no worries, I will take it -- this kind of fix makes more > sense in `rust-fixes` since they are treewide, i.e. it could have > triggered in more places at the same time since they changer the > compiler, and I have other few in the branch accumulated for Rust > 1.99.0. > > (An Acked-by is always nice of course!) I don't understand the rationale about being treewide. This patch only touches rust/kernel/device.rs. (Even if there would have been other subsystems running into the same condition, it would have produced independent patches, which could be - but don't have to be - sent in a treewide series.) I'm obviously fine with the patch and I also don't mind if you take it if you prefer to, thus: Acked-by: Danilo Krummrich <[email protected]> But, if I may be honest, the way this is presented feels as if the driver-core maintainers never had a say in the logistics in the first place, which doesn't feel right. Also what makes this patch urgent in a way that waiting for an ACK to be given before applying wasn't an option?