Re: [PATCH v2 1/2] rust_binder: Update looper_flags bitmaps to use kernel::impl_flags!
Greg Kroah-Hartman <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2026071928-tapered-tattered-8433@gregkh> |
On Sun, Jul 19, 2026 at 09:56:58AM +0000, Jahnavi MN via B4 Relay wrote: > From: Jahnavi MN <[email protected]> > > - Define `LooperFlags(u32)` and `LooperFlag` enum with 7 variants. > - Change `InnerThread.looper_flags` type to `LooperFlags`. > - Update looper state transitions and checks to use type-safe methods. > - Convert `looper_flags` to `u32` for hex formatting in `debug_print`. This is a list of things you did (i.e. what), but nothing about "why" you are doing this. Take a look at the kernel documentation for how to write good changelog text. It's usually the hardest part of making a patch, and these two should be rewritten a bit to explain why you are doing this type of conversion (i.e. the information in your patch 0/X should be in here, right?) thanks, greg k-h