Re: [PATCH v5 3/8] gpu: nova-core: add TLV parser for firmware files

Timur Tabi <[email protected]> Wed, 29 Jul 2026 23:02:32 +0000
Newsgroups org.kernel.vger.rust-for-linux,dev.linux.lists.driver-core,dev.linux.lists.nova-gpu
Message-ID <[email protected]>

On 7/29/26 3:09 PM, John Hubbard wrote:
> Agree that there is value in enforcing printable tags. We could
> something like this if we want to allow spaces:
> 
>     bytes.iter().all(|b| b.is_ascii_graphic() || *b == b' ')
> 
> ...but is there really-truly a need to support spaces? (I haven't checked
> on that, but it surprises me at first.)

For tags, no.

But this code is for the value in a string tag, so there could 
conceivably be spaces.

I posted a v6 which addresses this.