Re: [PATCH 05/24] irq & spin_lock: Add counted interrupt disabling/enabling

On Tue, Aug 04, 2026 at 09:26:40AM +0200, Peter Zijlstra wrote:
> On Mon, Aug 03, 2026 at 09:41:02PM -0700, Boqun Feng wrote:
> 
[...]
> > > +#else
> > > +extern void _local_interrupt_disable(void);
> > > +extern void _local_interrupt_enable(void);
> > > +#endif
> > > +
> > > +#else /* !MODULE */
> > > +extern void _local_interrupt_disable(void);
> > > +extern void _local_interrupt_enable(void);
> > 
> > I think the "extern" keywords are not necessary and ..
> 
> Probably, but I like them (and I know that other people hate on then).
> To me it makes it clear the definition is not here and should be sought
> elsewhere.
> 
> The extern really is needed for variables, but I also use it with
> functions for the same.
> 

Alright I will keep them, thanks!

Regards,
Boqun

> > > +#endif /* !MODULE */
> > >  
> 
[...]