Re: [PATCH] rust: io: Add a BigEndianMmio wrapper

Ethan Plant <[email protected]> Wed, 05 Aug 2026 18:41:31 -0700

Newsgroups	org.kernel.vger.rust-for-linux,dev.linux.lists.driver-core,org.kernel.vger.linux-kernel
Message-ID	<178598049138.1212746.2443151507074972963.b4-review@b4>

On Thu, 06 Aug 2026 00:21:09 +0200, Link Mauve <[email protected]> wrote:
> diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs
> index a38c20ba3d23e..a91979e4392ab 100644
> --- a/rust/kernel/io.rs
> +++ b/rust/kernel/io.rs
> @@ -1751,3 +1751,87 @@ macro_rules! io_write {
> [ ... skip 17 lines ... ]
> +        *self
> +    }
> +}
> +
> +/// I/O Backend for memory-mapped I/O, with relaxed access semantics.
> +pub struct BigEndianMmioBackend;

I don't think this backend has relaxed access semantics; this looks like
it may have been left over from `RelaxedMmio`.

Perhaps:

    /// I/O backend for memory-mapped I/O using big-endian accessors.

-- 
Ethan Plant <[email protected]>