Re: [PATCH] rust: macros: Allow omitting trailing commas in module!

Miguel Ojeda <[email protected]> Thu, 6 Aug 2026 14:08:07 +0200

Newsgroups	org.kernel.vger.rust-for-linux,org.kernel.vger.linux-kernel,org.kernel.vger.linux-modules
Message-ID	<CANiq72kXkY_CtxxedtpV1DykxGZ-SDwAYzAo6d_iDaVs7DthtA@mail.gmail.com>

On Thu, Aug 6, 2026 at 1:54 PM Gary Guo <[email protected]> wrote:
>
> Hmm, I am not sure if we really want this.
>
> `module!` invocation usually spans multiple lines so the formatting rules would
> always prefer adding trailing comma for this case.
>
> Allowing omitting sounds like encouraging bad practice.

Yeah, it also means inconsistency can be introduced for little gain.

Cheers,
Miguel