Re: [PATCH v15 1/2] rust: fmt: fix {:p} printing stack addresses

On 8/10/26 18:48, Gary Guo wrote:
> On Mon Aug 10, 2026 at 7:35 AM BST, Ke Sun wrote:
>> The `impl_fmt_adapter_forward!` macro forwards `Pointer` for
>> `Adapter<T>` by destructuring `self` into a local `t`, causing `{:p}`
>> to print the address of that temporary stack variable rather than the
>> actual pointer.
>>
>> Remove `Pointer` from the macro and provide a manual impl for
>> `Adapter<&T>` that passes `self.0` directly.
>>
>> Signed-off-by: Ke Sun <[email protected]>
> I don't think this has changed since last version. Usually you should pick up
> all tags provided for the previous series, so people know that it has been
> reviewed already and don't need to spend more time correlating it with the
> previous series.

Thanks for pointing that out — I dropped the tags. I'll use `b4 trailer` 
to check before
sending the next version.

Best regards,
Alvin

>
> (No need to resend just with tags picked up though)
>
> Best,
> Gary
>
>> ---
>>   rust/kernel/fmt.rs | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/rust/kernel/fmt.rs b/rust/kernel/fmt.rs
>> index 73afbc51ba33a..cd7d9664ff5b9 100644
>> --- a/rust/kernel/fmt.rs
>> +++ b/rust/kernel/fmt.rs
>> @@ -43,7 +43,14 @@ fn fmt(&self, f: &mut Formatter<'_>) -> Result {
>>       UpperExp,
>>       UpperHex, //
>>   };
>> -impl_fmt_adapter_forward!(Debug, LowerHex, UpperHex, Octal, Binary, Pointer, LowerExp, UpperExp);
>> +impl_fmt_adapter_forward!(Debug, LowerHex, UpperHex, Octal, Binary, LowerExp, UpperExp);
>> +
>> +impl<T: ?Sized + Pointer> Pointer for Adapter<&T> {
>> +    #[inline]
>> +    fn fmt(&self, f: &mut Formatter<'_>) -> Result {
>> +        Pointer::fmt(self.0, f)
>> +    }
>> +}
>>   
>>   /// A copy of [`core::fmt::Display`] that allows us to implement it for foreign types.
>>   ///
>
>