Re: [PATCH v2 14/16] rust: io: register: remove relative registers
"Alexandre Courbot" <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,dev.linux.lists.driver-core,dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
On Thu Aug 6, 2026 at 1:35 AM JST, Gary Guo wrote: > Relative registers can be better served by projection to subregion instead > of ad-hoc handling in register macro. Projection composes better (e.g. it > natively allows relative registers of relative registers without needing > additional support). > > Remove relative register support, and update the documentation to > demonstrate how projection and subregions can be used to achieve this > instead. > > Signed-off-by: Gary Guo <[email protected]> > --- > rust/kernel/io/register.rs | 474 +++++---------------------------------------- > 1 file changed, 52 insertions(+), 422 deletions(-) > > diff --git a/rust/kernel/io/register.rs b/rust/kernel/io/register.rs > index 49a61da106c7..295b06dd53a7 100644 > --- a/rust/kernel/io/register.rs > +++ b/rust/kernel/io/register.rs > @@ -8,7 +8,7 @@ > //! > //! Note: most of the items in this module are public so they can be referenced by the macro, but > //! most are not to be used directly by users. Outside of the `register!` macro itself, the only > -//! items you might want to import from this module are [`WithBase`] and [`Array`]. > +//! items you might want to import from this module is [`Array`]. nit: "items" should now be singular.