Re: [PATCH v6 2/3] drm/tyr: add GPU reset infrastructure
"Danilo Krummrich" <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri Aug 21, 2026 at 5:58 PM CEST, Onur Özkan wrote: > On Fri, 21 Aug 2026 12:31:03 -0300 > Daniel Almeida <[email protected]> wrote: >> I’d use dev_info instead, I don’t think a reset belongs in dev_dbg. > > It was dev_dbg initially, Danillo said otherwise and I changed it. I have no > strong feeling on both. Why do you think it is useful to print "Starting GPU reset." and "GPU reset completed." with dev_info()? How does this help users or help with debugging? In general, if drivers work properly they should remain silent. A successful reset means it worked properly. What you rather want to print, likely with dev_warn() or dev_err(), is what caused the GPU reset to be performed in the first place.