Re: [PATCH v6 2/3] drm/tyr: add GPU reset infrastructure
"Danilo Krummrich" <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri Aug 21, 2026 at 6:39 PM CEST, Daniel Almeida wrote: > My point is that resetting the GPU should not be a “debug” trace, but rather > something that should hit dmesg unconditionally. Of all things that are > printed on a driver, a “hey the GPU is being reset because something crashed” > is something that should always show up IMHO. Please see my reply in [1]. If something crashed, please feel free to add a dev_warn() or dev_err() print about the exact error condition. But please do not add dev_info() prints about things that were successful and just bloat dmesg. In this specific case you want the caller of ResetHandle::schedule() to print about *why* the reset work was scheduled. You also already have a dev_err() print when the GPU reset failed. So, at this point you're good already. Additional prints about when exactly the reset work starts and when it completes is stuff for dev_dbg(). [1] https://lore.kernel.org/all/[email protected]/