Re: [PATCH v6 2/3] drm/tyr: add GPU reset infrastructure
"Danilo Krummrich" <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri Aug 21, 2026 at 7:23 PM CEST, Daniel Almeida wrote: > I agree, no argument from me there. The problem is, when the GPU is resetting, > things are far from "working". In fact, things went so bad somewhere that it > brought the device down for everybody, and the system is taking steps to (try > to) bring it up again. > > As a user, I very much appreciated this when games went down, it made me think > that the problem was important enough to report, and also likely explained why, > in that particular hardware, things didn't really work 100% well afterwards, > which prompted me to reboot the machine. > > Two outcomes could have come from that, a) filing a bug on the game itself, and > b) telling the kernel guys that their reset code wasn't really working 100% > well either. > > I do agree that "Starting GPU reset" is frivolous, but at least a message > saying that a reset took place, either sucessfully or not, is better than > silence. I had a brief look at panthor, and it seems to me that this reset only ever happens when the hardware is truely malfunctioning. I.e. it never runs under "normal" error conditions, right? In that case, I think it's fine. But I'd still rather print where the error occurs and about the error / recovery condition. The "Starting GPU reset" one still doesn't seem overly useful to me. In general, the reset prints should still hint some additional information that helps to understand the root cause.