Re: [PATCH] rust: net: phy: fix off-by-one bit positions in device status accessors

Andrew Lunn <[email protected]>
Newsgroups org.kernel.vger.rust-for-linux,org.kernel.vger.netdev
Message-ID <[email protected]>
On Sun, Aug 23, 2026 at 07:56:53PM +0800, springbreeze wrote:
> Thanks, that makes sense. I will keep v2 to the minimal bit-number fix (with
> Cc: stable) and send the switch to the bindgen-generated accessors as a
> separate follow-up patch once the fix lands.

Did you look at the history. Was this always wrong? Or was a new bit
added at some point, moving them by one?

If it was always wrong, updating the hard coding is not so bad. But if
a new bit has been added, using bindgen would be a better fix, since
it will always be correct.

   Andrew
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.