Re: [PATCH v4 3/7] drm: nova: Add chipid enum to nova-drm UAPI
M Henning <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAAgWFh0VvY4D=-Se+bVO1YonRNFEa28nc7+ZbxEbv6en7oPaDw@mail.gmail.com> |
On Tue, Aug 11, 2026 at 1:12 AM Alistair Popple <[email protected]> wrote: > +/* > + * Opaque chipids. These may be used to determine what chip a particular GPU is > + * based on the identifier but the values themselves should not be assumed to > + * carry any particular meaning. > + */ You say this is opaque, but the userspace MR you posted already treats the values as non-opaque in eg. sm_for_chipset. https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/43352/diffs?commit_id=945a8e7c51939577526974b342c8dc6bafc3372f So, I guess my question is, is is opaque or not? I don't see much of a reason to make it opaque since the chipset has had the same structure on the hardware level for 30 years, so I don't expect it to change too often. Truly treating this as opaque would likely require a small refactor on the userspace side without much value. (I realize this has already been discussed a bit on the previous version.)