[PATCH v6 0/2] drm/tyr: add Job IRQ handling
Laura Nao <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Changes in v6: - Split changes into two separate commits: the first one creates a new file with TyrIrq/TyrIrqTrait and their related impls, the second commit imports and uses TyrIrq/TyrIrqTrait from crate::irq instead of crate::driver - Removed irq() accessor, unmasking the interrupts in TyrIrq::request() by accessing the private irq field directly instead - Add JobIrqMaskGuard to mask the Job IRQ before free_irq() runs, fixing incorrect drop order in the IRQ teardown path - Combined fw_ready/job_irq_wait into a separate JobIrqEvents type - Store firmware-ready state only once and always wake waiters unconditionally - Clear the status once the handler has been successfully registered - Use mask() in reenable_mask() to reduce code duplication - Reworded commit messages to reflect the changes - Link to v5: https://lore.kernel.org/r/[email protected] Changes in v5: - Implement PinnedDrop on TyrIrq to clear the interrupt mask on teardown - Link to v4: https://lore.kernel.org/r/[email protected] Changes in v4: - Replaced c_str! with C-String in irq.rs - Moved clear_status() before handle() in handle_threaded(), to avoid losing events if hw re-asserts the bit while handle() is running. - Only unmask interrupt sources in job_irq_init() when the handler is correctly registered. - Link to v3: https://lore.kernel.org/r/[email protected] Changes in v3: - Propagated request_threaded_irq_by_name safety requirement up the call chain, made TyrIrq::request() and job_irq_init() unsafe - Dropped CSG bits masking, added TODO comment to note this will be handled at a later stage. Reworded commit message to reflect the change. - Added documentation for TyrIrqTrait, TyrIrq, JobIrq and job_irq_init() - Link to v2: https://lore.kernel.org/r/[email protected] Changes in v2: - Dropped Wait custom type in favor of WaitQueue - Renamed JobIrq lifetime to generic 'a This series follows up to [1], which adds support for firmware loading and MCU booting to the Tyr driver. The changes included here were originally introduced in its v4[2], then dropped to reduce the scope of the series, and have been adjusted to work with the HRT (Higher-Ranked Lifetime Types) driver architecture recently introduced. The series adds a threaded IRQ wrapper for the firmware Job interrupts, used to signal events from the global CSF (GLB) and Command Stream Group (CSG) interfaces. These changes will be later used to wait for global CSF interface readiness after firmware boot, as part of the CSF firmware interfaces support that will be submitted as a separate series. This series is based on drm-rust-next and depends on: - [PATCH v2] rust: irq: make Registration compatible with lifetime-bound drivers[3] - [PATCH 0/5] rust: sync: add WaitQueue infrastructure[4] Note: [4] doesn't apply cleanly on drm-rust-next at the moment, due to missing changes in rust/kernel/sync/lock/spinlock.rs[5]. I've applied all dependencies and fixed conflicts for the purpose of testing this patch on top of drm-rust-next, a branch with these changes is available here: https://gitlab.freedesktop.org/laura.nao/linux/-/commits/b4/tyr-irq-v6 [1] https://lore.kernel.org/all/[email protected]/ [2] https://lore.kernel.org/rust-for-linux/[email protected]/ [3] https://lore.kernel.org/rust-for-linux/[email protected]/ [4] https://lore.kernel.org/rust-for-linux/[email protected]/ [5] https://lore.kernel.org/all/[email protected]/ Signed-off-by: Laura Nao <[email protected]> --- Laura Nao (2): drm/tyr: add TyrIrq threaded IRQ wrapper drm/tyr: add Job IRQ handling drivers/gpu/drm/tyr/fw.rs | 1 + drivers/gpu/drm/tyr/fw/irq.rs | 174 ++++++++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/tyr/irq.rs | 114 +++++++++++++++++++++++++++ drivers/gpu/drm/tyr/tyr.rs | 1 + 4 files changed, 290 insertions(+) --- base-commit: d7962d990307dc28dfded8cf6ba96d7498af7631 change-id: 20260728-tyr-irq-v2-0b3c5022be33 Best regards, -- Laura Nao <[email protected]>