Re: [PATCH v3 2/2] rust: crypto: add synchronous RSA akcipher support
Miguel Ojeda <[email protected]>
| Newsgroups | org.kernel.vger.rust-for-linux,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CANiq72k3COcjo1s1MXdh=K7qRcOMMSq7-3_JCMtNKN3J0zQmjg@mail.gmail.com> |
On Thu, Aug 27, 2026 at 5:05 AM Eric Biggers <[email protected]> wrote: > > As I've been commenting on other of these bindings patches, it also > doesn't really make sense to have the kconfig symbol be in lib/ but then > have the actual code be in rust/. They should be in the same place. Did you see my reply at https://lore.kernel.org/rust-for-linux/CANiq72=uUR4Vo9W55Kq6tQjc+6Q4_+wiWhCo-VLdkvg6PJeoAw@mail.gmail.com/ ? But if you feel strongly about it, I guess it can be temporarily placed elsewhere, i.e. Kconfig symbols are not tied to the path anyway so they should be easy to move later on. > > +__rust_helper void rust_helper_memzero_explicit(void *s, size_t count) > > +{ > > + memzero_explicit(s, count); > > +} > > Isn't there a standard Rust solution for this? If you mean a function in the standard library to zero memory without being optimized out: no, there isn't. For context: I added `memset_explicit` to the ISO C standard and informally asked upstream Rust about adding an equivalent function many years ago, but at least back then they didn't want to add it (or at least in a way similar to how it is specified in C, which doesn't really give guarantees, letting compiler writers do their best effort). I guess I can ask again since now we would finally have an actual user in Linux... :) I hope that helps! Cheers, Miguel