Re: [PATCH] rasdaemon (replacement for mcelog)

On 3/8/21 3:59 AM, Dominick Grift wrote:
> Dominick Grift <[email protected]> writes:
> 
>> Russell Coker <[email protected]> writes:
>>
>>> This is policy for rasdaemon, the new replacement for mcelog.  The
>>> /dev/mcelog device is now an obsolete kernel feature that can be enabled
>>> for backward compatibility and rasdaeon with tracefs is the new way.
>>>
>>> I've tested this and it seems to work OK, but all my servers are working
>>> well so I haven't been able to test the case of actually detecting an
>>> error.  It would be good if someone with a known damaged server could give
>>> it a go.
>>>
>>> I think this is ready for merging.
>>>
>>> Signed-off-by: Russell Coker <[email protected]>
>>>
[...]
>>> +++ refpolicy-2.20210203/policy/modules/services/rasdaemon.te
>>> @@ -0,0 +1,49 @@
>>> +policy_module(rasdaemon, 1.0.0)
>>> +
>>> +# rasdaemon is a RAS (Reliability, Availability and Serviceability) logging
>>> +# tool.  It currently records memory errors, using the EDAC tracing events.
>>> +# EDAC are drivers in the Linux kernel that handle detection of ECC errors
>>> +# from memory controllers for most chipsets on x86 and ARM architectures.
>>> +#
>>> +# https://git.infradead.org/users/mchehab/rasdaemon.git
>>
>> Please use the <summary></summary> for description. We have an api
>> browser (make doc) and the description should end up there as well.
>>
>> <summary>Reliability, Availability and Serviceability (RAS) logging tool.</summary>
>>
>> I would omit the url because those are often subject to change anyway.

I agree if we have this amount of description it should go in the XML, but the 
module level actually has a <desc> tag that goes after <summary>.  I like 
Dominick's summary, but the Russel's comment can go in the module <desc>.

The URL can remain.  Yes, it can change, but at least there are some breadcrumbs 
if this program becomes obsolete or unmaintained.

-- 
Chris PeBenito