Re: [PATCH testsuite 1/2] tests/file_contexts: refactor existing tests

Thiébaud Weksteen <[email protected]> Wed, 22 Jul 2026 10:07:31 +1000

Newsgroups	org.kernel.vger.selinux
Message-ID	<CA+zpnLfh7fq-_bqLwUULkmr5skci+mtJe+=5PH1PKB6cwqWmuA@mail.gmail.com>

On Wed, Jul 22, 2026 at 1:50 AM Stephen Smalley
<[email protected]> wrote:
>
> On Mon, Jul 20, 2026 at 10:12 PM Thiébaud Weksteen <[email protected]> wrote:
> >
> > Change the logging format when reporting an error to better capture the
> > location and context of the error.
> >
> > Split tests into functions to better isolate the tested behaviour.
> >
> > Format tests using clang-format.
> >
> > Signed-off-by: Thiébaud Weksteen <[email protected]>
>
> To date, the selinux-testsuite has used tools/check-syntax for
> formatting and this doesn't match the clang-format. Not fundamentally
> opposed to migrating the testsuite to match the userspace but that's
> up to Ondrej/Paul and should likely be done as a separate series on
> its own.

Sorry for that, I reused my clang-format command from the libselinux patches.
I'll update this patch and send a new version.

And yes, +1 to any possible alignment on the formatting. Thanks.