Re: [PATCH v3 1/2] checkpolicy: extend bad-data tests for type, role, and user errors

Akhil Kohli <[email protected]> Thu, 30 Jul 2026 12:26:24 +0200
Newsgroups org.kernel.vger.selinux
Message-ID <CANu4e6PYkZ8--vBPskdhcFtij6T2dZvxu+MX4gb2KcNRaNxV=w@mail.gmail.com>
Thanks for catching that. Fixed in v4:
https://lore.kernel.org/selinux/[email protected]/

On Wed, Jul 29, 2026 at 3:24 PM Stephen Smalley
<[email protected]> wrote:
>
> On Tue, Jul 28, 2026 at 12:47 PM Akhil Kohli <[email protected]> wrote:
> >
> > Add negative .te fixtures for duplicate type/attribute declarations,
> > type/attribute name conflicts, invalid type names, and malformed role
> > and user stanzas. Run checkmodule negative tests as non-root in CI so
> > the unreadable .te case is exercised outside root-only skips.
> >
> > Signed-off-by: Akhil Kohli <[email protected]>
> > ---
>
> > diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
> > index 4322ddff..fd78969f 100644
> > --- a/.github/workflows/run_tests.yml
> > +++ b/.github/workflows/run_tests.yml
> > @@ -94,6 +94,17 @@ jobs:
> >            sudo userdel -r bad-data-test 2>/dev/null || true
> >            echo "::endgroup::"
> >          fi
> > +
>
> Trailing whitespace here, git should have warned you about it.
>