Re: [RFC PATCH 5/7] kernel_user_data: track parameter __untagged annotations

On Tue, Oct 08, 2019 at 11:24:42AM +0300, Dan Carpenter wrote:
> On Mon, Oct 07, 2019 at 04:35:43PM +0100, Andrew Murray wrote:
> > @@ -1168,6 +1211,8 @@ static void set_param_user_data(const char *name, struct symbol *sym, char *key,
> >  	state = alloc_estate_rl(rl);
> >  	if (param_data_capped(value) || is_capped(expr))
> >  		estate_set_capped(state);
> > +	if (param_data_treat_untagged(value) || sym->ctype.as == 5)
> > +		estate_set_treat_untagged(state);
> 
> Could you update to the latest version of Smatch?  These days cytype.as
> address space is a pointer instead of an int.
> 
> smatch_kernel_user_data.c: In function ‘set_param_user_data’:
> smatch_kernel_user_data.c:1225:56: warning: comparison between pointer and integer
>   if (param_data_treat_untagged(value) || sym->ctype.as == 5)
>                                                         ^~

Doh! Thanks, I did rebase to the latest version before sending and checked it
built - though missed this warning.

I'll fix up the code on the next respin.

Andrew Murray

> 
> regards,
> dan carpenter
>