[PATCH] Clean up unused -W options

John Levon <[email protected]>
Newsgroups org.kernel.vger.smatch
Message-ID <[email protected]>
-Wbig-constants and -Wnon-ansi-function-declarations were obsoleted
by other named options; clean up the remaining bits of them.
---
 lib.c                                      |  4 ----
 lib.h                                      |  2 --
 sparse.1                                   | 14 --------------
 validation/non-ansi-function-declaration.c | 10 ----------
 4 files changed, 30 deletions(-)
 delete mode 100644 validation/non-ansi-function-declaration.c

diff --git a/lib.c b/lib.c
index 4afeb340..dbe62622 100644
--- a/lib.c
+++ b/lib.c
@@ -255,7 +255,6 @@ static struct token *pre_buffer_end = NULL;
 
 int Waddress = 0;
 int Waddress_space = 1;
-int Wbig_constants = 1;
 int Wbitwise = 1;
 int Wbitwise_pointer = 0;
 int Wcast_from_as = 0;
@@ -275,7 +274,6 @@ int Wint_to_pointer_cast = 1;
 int Wenum_mismatch = 1;
 int Wsparse_error = 0;
 int Wmemcpy_max_count = 1;
-int Wnon_ansi_function_declaration = 1;
 int Wnon_pointer_null = 1;
 int Wold_initializer = 1;
 int Wold_style_definition = 1;
@@ -639,7 +637,6 @@ static char **handle_switch_o(char *arg, char **next)
 static const struct flag warnings[] = {
 	{ "address", &Waddress },
 	{ "address-space", &Waddress_space },
-	{ "big-constants", &Wbig_constants },
 	{ "bitwise", &Wbitwise },
 	{ "bitwise-pointer", &Wbitwise_pointer},
 	{ "cast-from-as", &Wcast_from_as },
@@ -658,7 +655,6 @@ static const struct flag warnings[] = {
 	{ "init-cstring", &Winit_cstring },
 	{ "int-to-pointer-cast", &Wint_to_pointer_cast },
 	{ "memcpy-max-count", &Wmemcpy_max_count },
-	{ "non-ansi-function-declaration", &Wnon_ansi_function_declaration },
 	{ "non-pointer-null", &Wnon_pointer_null },
 	{ "old-initializer", &Wold_initializer },
 	{ "old-style-definition", &Wold_style_definition },
diff --git a/lib.h b/lib.h
index 1ef5f524..8895ddaa 100644
--- a/lib.h
+++ b/lib.h
@@ -139,7 +139,6 @@ extern int preprocess_only;
 
 extern int Waddress;
 extern int Waddress_space;
-extern int Wbig_constants;
 extern int Wbitwise;
 extern int Wbitwise_pointer;
 extern int Wcast_from_as;
@@ -159,7 +158,6 @@ extern int Wimplicit_int;
 extern int Winit_cstring;
 extern int Wint_to_pointer_cast;
 extern int Wmemcpy_max_count;
-extern int Wnon_ansi_function_declaration;
 extern int Wnon_pointer_null;
 extern int Wold_initializer;
 extern int Wold_style_definition;
diff --git a/sparse.1 b/sparse.1
index 3c65748a..9a622ab2 100644
--- a/sparse.1
+++ b/sparse.1
@@ -56,13 +56,6 @@ Sparse issues these warnings by default.  To turn them off, use
 \fB\-Wno\-address\-space\fR.
 .
 .TP
-.B \-Wbig-constants
-Warn about large integer constants that are not qualified by a size suffix.
-
-Sparse issues these warnings by default.  To turn them off, use
-\fB\-Wno\-big\-constants\fR.
-.
-.TP
 .B \-Wbitwise
 Warn about unsupported operations or type mismatches with restricted integer
 types.
@@ -287,13 +280,6 @@ The limit can be changed with \fB\-fmemcpy\-max\-count=COUNT\fR,
 the default being \fB100000\fR.
 .
 .TP
-.B \-Wnon\-ansi\-function\-declaration
-Warn about non-ANSI function declarations.
-
-Sparse issues these warnings by default.  To turn them off, use
-\fB\-Wno\-non\-ansi\-function\-declaration\fR.
-.
-.TP
 .B \-Wnon\-pointer\-null
 Warn about the use of 0 as a NULL pointer.
 
diff --git a/validation/non-ansi-function-declaration.c b/validation/non-ansi-function-declaration.c
deleted file mode 100644
index 48a72948..00000000
--- a/validation/non-ansi-function-declaration.c
+++ /dev/null
@@ -1,10 +0,0 @@
-
-
-extern void myfunction(), myfunc2();
-
-/*
- * check-name: -Wno-non-ansi-function-declaration works
- * check-command: sparse -Wno-non-ansi-function-declaration $file
- * check-error-start
- * check-error-end
- */
-- 
2.17.1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.