Re: [PATCH] check_netdev_priv: warn about using netdev priv data after free_netdev

Pavel Skripkin <[email protected]> Wed, 4 Aug 2021 17:40:22 +0300
Newsgroups org.kernel.vger.smatch
Message-ID <[email protected]>
On 8/4/21 5:35 PM, Dan Carpenter wrote:
> Pushed!
> 
> This finds two bugs in my allmodconfig.  They're both real bugs.
> 
> drivers/net/ethernet/freescale/fec_main.c:3994 fec_drv_remove() error: Using fep after free_{netdev,candev}(ndev);
> drivers/net/ethernet/freescale/fec_main.c:3995 fec_drv_remove() error: Using fep after free_{netdev,candev}(ndev);
> drivers/net/ethernet/neterion/vxge/vxge-main.c:3518 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);
> drivers/net/ethernet/neterion/vxge/vxge-main.c:3518 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);
> drivers/net/ethernet/neterion/vxge/vxge-main.c:3520 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);
> drivers/net/ethernet/neterion/vxge/vxge-main.c:3520 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev);
> 

Wow!

I did't test it with allmodconfig, but I've tested it with my config for 
reproducing syzkaller bugs.

I've fixed few bugs while writing this checker and fixes are already 
upstreamed.

> Presumably you already sent fixes or reported these?
> 
> regards,
> dan carpenter
> 


With regards,
Pavel Skripkin