Re: [PATCH v2 net] ice: Fix freeing uninitialized pointers

Markus Elfring <[email protected]> Sat, 23 Mar 2024 17:56:29 +0100

Newsgroups	org.kernel.vger.smatch,org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.osuosl.intel-wired-lan
Message-ID	<[email protected]>

> Automatically cleaned up pointers need to be initialized before exiting
> their scope.  In this case, they need to be initialized to NULL before
> any return statement.

* May we expect that compilers should report that affected variables
  were only declared here instead of appropriately defined
  (despite of attempts for scope-based resource management)?

* Did you extend detection support in the source code analysis tool “Smatch”
  for a questionable implementation detail?


Regards,
Markus