Re: [PATCH] pre-proc: use uname() syscall instead of invoking uname
Dan Carpenter <[email protected]> Fri, 10 May 2024 18:18:57 +0300
| Newsgroups | org.kernel.vger.smatch |
|---|---|
| Message-ID | <[email protected]> |
On Fri, May 10, 2024 at 05:12:14PM +0200, Andrey Albershteyn wrote:
> Not all systems have uname at /bin/uname and using uname() directly
> seems to be a better case than spawning shell.
>
> The utsname.sysname seems to be returning different name ("Linux"
> instead of "GNU/Linux") but this doesn't seem to be a problem.
> "uname -o" does seem to be returning HOST_OPERATING_SYSTEM and
> utsname.sysname being defined as KERNEL_NAME.
>
> Signed-off-by: Andrey Albersteyn <[email protected]>
Hi Andrey,
Thanks for this patch but this is code from Sparse. Could you send it
to send the patch to [email protected] instead? If they
don't apply it then I will apply it to the Smatch repository.
regards,
dan carpenter