Re: min/max() changes

Hello Dan,

On 02/08/24 22:34, Harshit Mogalapalli wrote:
> On 02/08/24 22:30, Dan Carpenter wrote:
>> On Fri, Aug 02, 2024 at 11:41:05AM -0500, Dan Carpenter wrote:
>>> 4) Smatch thinks functions are dereferencing parameters when they are
>>>     not.  Code like "foo = min(param ? param->bar : xxx, yyy);"  The
>>>     "param" variable isn't dereferenced without checking.
>>
>> Wow wow wow.  Smatch no longer thinks that nfsacl_size() dereferences
>> "acl".  That's it folks!  That's the whole ball game!  Four for Four!
>> Smatch no longer has any bugs!  I'm going to retire to an island now
>> that I have fixed everything.
>>
>> ;)
> 
> Oh wow!
> 
> All of them fixed, yayy!

Tested this, with latests smatch and linux-next, the db builds successfully!


Thanks,
Harshit
> 
>>
>> Let me know if you see any other bugs from the min/max() changes.  Or
>> any bugs at all really.  Feel free.
>>
>> regards,
>> dan carpenter
>>
> Regards,
> Harshit
>